Greptile Summary

This PR adds a user-scoped custom dashboard views feature to the existing dashboard page, allowing users to persist named subsets of dashboard panels with optional filter presets. The implementation covers the full stack: a new DashboardView Prisma model with migration, four new tRPC procedures, a tab bar UI on the dashboard page, a ViewBuilderDialog for creating/editing views, and a CustomView component that fetches only the data required by the selected panels.

Key observations:

• The previously flagged issues (missing withAudit, onSuccess resetting active view on any delete, and the sortOrder TOCTOU race) have all been addressed in this revision.
• All three write mutations (createView, updateView, deleteView) still use .use(withTeamAccess("VIEWER")) rather than the correct "EDITOR" role required by the project's RBAC policy for create/modify operations — this was flagged in a prior review thread and remains unresolved.
• The delete handler in page.tsx uses selectedEnvironmentId! (a non-null assertion) instead of the ?? "" fallback used by the create and update paths, which will produce a runtime BAD_REQUEST when a user attempts to delete a view with no environment currently selected.

Confidence Score: 2/5

• Not safe to merge — write mutations use the wrong RBAC role and the delete handler has a null-safety bug that produces a runtime error.
• Two concrete, unresolved correctness issues remain: (1) all three write mutations gate on VIEWER instead of EDITOR, violating the project's role hierarchy contract; (2) the delete mutation passes a potentially-null environmentId due to a non-null assertion, causing a guaranteed Zod validation failure when no environment is selected. Both issues will manifest under normal usage.
• src/app/(dashboard)/page.tsx (null-safety bug in delete handler) and src/server/routers/dashboard.ts (incorrect RBAC role on all three write mutations).

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant U as User (Browser)
    participant P as page.tsx
    participant VB as ViewBuilderDialog
    participant CV as CustomView
    participant R as dashboard router (tRPC)
    participant DB as PostgreSQL

    U->>P: Load dashboard
    P->>R: listViews (protectedProcedure)
    R->>DB: SELECT * FROM DashboardView WHERE userId = ?
    DB-->>R: DashboardView[]
    R-->>P: views[]
    P-->>U: Render tab bar (Default + custom tabs)

    U->>P: Click "+ New View"
    P->>VB: open=true
    U->>VB: Enter name + select panels → Save
    VB->>R: createView (VIEWER + withAudit)
    R->>DB: aggregate(_max sortOrder) → INSERT DashboardView
    DB-->>R: new DashboardView
    R-->>VB: created view
    VB->>P: invalidateQueries listViews + close

    U->>P: Click custom view tab
    P->>CV: render CustomView(view)
    CV->>R: chartMetrics / stats / pipelineCards (conditional)
    R->>DB: query metrics
    DB-->>R: data
    R-->>CV: panel data
    CV-->>U: Render selected panels

    U->>P: Click delete icon → confirm
    P->>R: deleteView (VIEWER + withAudit)
    R->>DB: SELECT + DELETE DashboardView WHERE id = ?
    DB-->>R: ok
    R-->>P: {deleted: true}
    P->>P: invalidateQueries + conditionally reset activeView

_{Last reviewed commit: 9998bfc}